Fix assertion -- an import may come from a require() call #19667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Nov 1, 2017
| ////export const foo = 0; | ||
|
|
||
| // @Filename: /b.js | ||
| ////const a = require("./a"); |
There was a problem hiding this comment.
also add a test for import("./a");
mhegazy
approved these changes
Nov 1, 2017
|
Please port this to release-2.6 |
ghost
force-pushed
the
completionsimport_require
branch
from
2308d78 to
e23ddc6
Compare
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Nov 7, 2017
* Fix assertion -- an import may come from a require() call
* Add test for `import("./a")`
ghost
mentioned this pull request
aluanhaddad
pushed a commit
to aluanhaddad/TypeScript
that referenced
this pull request
Nov 7, 2017
…19667) * Fix assertion -- an import may come from a require() call * Add test for `import("./a")`
ghost
pushed a commit
that referenced
this pull request
Nov 7, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19629