Strip "/index" from import fix module specifiers #19962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,7 +322,7 @@ namespace ts.codefix { | |||
| tryGetModuleNameAsNodeModule(options, moduleFileName, host, getCanonicalFileName, sourceDirectory) || | |||
| tryGetModuleNameFromBaseUrl(options, moduleFileName, getCanonicalFileName) || | |||
| options.rootDirs && tryGetModuleNameFromRootDirs(options.rootDirs, moduleFileName, sourceDirectory, getCanonicalFileName) || | |||
| removeFileExtension(getRelativePath(moduleFileName, sourceDirectory, getCanonicalFileName)); | |||
| removeExtensionAndIndexPostFix(getRelativePath(moduleFileName, sourceDirectory, getCanonicalFileName)); | |||
There was a problem hiding this comment.
You shouldnt be removing file index when module resolution is not node_modules right? Because classicModuleResolver doesnt auto lookup for file with name of index in moduleName directory?
|
Needs test case for classic node resolver for
|
ghost
mentioned this pull request
ghost
force-pushed
the
importNameCodeFixNewImportIndex
branch
from
1b4d504 to
30dad34
Compare
sheetalkamat
approved these changes
Nov 16, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19957