With classic resolution, don't provide import for a location inside node_modules #20371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
importCodeFix_noClassic
branch
from
b82c25e to
dffcabb
Compare
sheetalkamat
reviewed
Dec 1, 2017
| return [relativePath]; | ||
| // Don't use a relative path that would pass through node_modules -- should have handled that that in `tryGetModuleNameAsNodeModule`, | ||
| // but would do nothing there if we're in classic resolution, so return no result in that case. | ||
| return forEachAncestorDirectory(relativePath, p => getBaseFileName(p) === "node_modules" ? true : undefined) ? [] : [relativePath]; |
There was a problem hiding this comment.
why not just check module resolution strategy is classic resolver when doing this?
There was a problem hiding this comment.
Actually, now I'm thinking we shouldn't do anything here.
We're providing an import fix for that file because the file has already been included in the project. In the case of this test, that's because fourslash adds all the files to the language service. In a real scenario that would only happen if the file had already been imported somehow.
So I think it would suffice to just test that the import fix is for a relative path and not a global import. Does that sound right?
ghost
mentioned this pull request
|
Closing in favor of #20453. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20050