Always check a return expression in a generator #20621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
checkGeneratorReturn
branch
from
86cadee to
d021bce
Compare
|
There is #18726 for checking the return type at all. That also links to a PR but it seems to be conflicting now. |
|
@Kovensky thanks |
sandersn
approved these changes
Dec 12, 2017
| // A generator does not need its return expressions checked against its return type. | ||
| // Instead, the yield expressions are checked against the element type. | ||
| // TODO: Check return expressions of generators when return type tracking is added | ||
| // TODO: Check return types of generators when return type tracking is added |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20587
#20326 accidentally changed it so return expressions in generators were never checked. This PR cleans up the control flow so we will still check the expression (though we don't check its type -- there's a TODO comment but is there an issue for that?).