Remove isGlobalCompletionScope #21342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
we did add this one for a reason... can you check with @amcasey what it is used for. i can not recall why we added to be frank. |
|
I think it might control whether or not we offer snippets during completion. |
|
Yes, it appears to be used exclusively for determining whether or not to ask for available snippets while populating the completion list. |
ghost
mentioned this pull request
|
Closing in favor of #21973. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate fix for #21330
Now if we're providing global completions, we always set
isGlobalCompletionto true, regardless of whether we're in a statement vs expression.I believe the original motivation for this check was to avoid setting
isGlobalCompletionto true inside of imports and such -- but we also don't want to be searching for global symbols in that case, and we now don't. I don't think there's any situation where we do want to provide global symbols but don't wantisGlobalCompletionto be true.CC @jramsay who originally did #11338 and #11647 for potential review.
Discovered #21341 along the way.