Skip to content

Fix initializer assignability for unique symbol #21585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2018
Merged

Fix initializer assignability for unique symbol #21585

merged 1 commit into from
Feb 6, 2018

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Feb 2, 2018

Uses a separate property on SymbolLinks to hold the unique symbol type of a node so as not to collide with a type annotation on the node.

Fixes #21584

@mhegazy
Copy link
Contributor

mhegazy commented Feb 5, 2018

Please port this change to release-2.7 as well.

@rbuckton
Copy link
Contributor Author

rbuckton commented Feb 5, 2018

Done

@rbuckton rbuckton merged commit 3b73ce4 into master Feb 6, 2018
@rbuckton rbuckton deleted the fix21584 branch February 6, 2018 19:30
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @mhegazy