Skip to content

In getSymbolAtLocation, return undefined instead of unknownSymbol #21774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Feb 8, 2018
Merged

In getSymbolAtLocation, return undefined instead of unknownSymbol #21774

2 commits merged into from
Feb 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2018

This is more consistent with the other return values from getSymbolAtLocation.
Also fixes a bug discovered while investigating #21772, since we check for undefined but not unknownSymbol in recordUsagebySymbol in extractSymbol.ts.

@ghost ghost requested review from weswigham and sandersn February 8, 2018 21:47
@ghost ghost merged commit e2178ec into master Feb 8, 2018
@ghost ghost deleted the extract-method_jsxIntrinsicTagSymbol branch February 8, 2018 22:35
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weswigham weswigham Awaiting requested review from weswigham

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhegazy