Check inferred constraints for 'infer X' type variables #22323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we properly check inferred constrains for
infer X
type variables in conditional types. Specifically, during type inference in a conditional type, when a candidate type for aninfer X
type variable doesn't satisfy the constraint inferred for that type variable (see #21709), the candidate is replaced with the constraint. That will subsequently cause the conditional check to be false. For example:Previously,
T2
would be the type42
which doesn't satisfy the constraintstring
inferred fromMustBeString
.Fixes #22221.