Skip to content

[release-2.8] Combine keyof T inferences (#22525) #22708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

DanielRosenwasser
Copy link
Member

Ports #22525 to release-2.8

  • Combine keyof T inferences

  • Extract covariant inference derivation into function

  • Test:keyof inference lower priority than return inference

for #22376

  • Update 'expected' comment in keyofInferenceLowerPriorityThanReturn

  • Update comment in test too, not just baselines

  • Fix typo

  • Move tests

Fixes #

* Combine keyof T inferences

* Extract covariant inference derivation into function

* Test:keyof inference lower priority than return inference

for #22376

* Update 'expected' comment in keyofInferenceLowerPriorityThanReturn

* Update comment in test too, not just baselines

* Fix typo

* Move tests
@DanielRosenwasser DanielRosenwasser merged commit 0f024f5 into release-2.8 Mar 20, 2018
@DanielRosenwasser DanielRosenwasser deleted the combineKeyofInferenceRelease-2.8 branch March 20, 2018 01:20
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants