Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make T[never] = never instead of erroring or being any #22787

Merged
merged 4 commits into from
Mar 27, 2018
Merged

Make T[never] = never instead of erroring or being any #22787

merged 4 commits into from
Mar 27, 2018

Commits on Mar 27, 2018

  1. Add tests showing existing behavior for indexing types with never.

    @kpdonn
    kpdonn committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    87a2d33 View commit details
    Browse the repository at this point in the history

  2. Make T[never] = never instead of erroring or being any. 

    And update the baselines for the tests for this change.
    @kpdonn
    kpdonn committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    f0ca9ec View commit details
    Browse the repository at this point in the history

  3. Add test case for indexing an expression with never showing existing … 

    …behavior.
    @kpdonn
    kpdonn committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    7f95ca5 View commit details
    Browse the repository at this point in the history

  4. Make indexing an object with never expression result in never. 

    And update baseline to reflect new behavior.
    @kpdonn
    kpdonn committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    5d19c69 View commit details
    Browse the repository at this point in the history