Work around bug with global completion with invalid identifier #23086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Apr 2, 2018
Contributor
mhegazy
left a comment
mhegazy
left a comment
There was a problem hiding this comment.
Please port to release-2.8 as well
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Apr 2, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Apr 2, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21790
Don't really know what the cause of the crash is, but this will make us to go ahead with an invalid identifier global completion instead of crashing.