In JS, class supports @template tag for declaring type parameters
#23511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to do the following: 1. Correctly get jsdoc host in predicate. 2. Make this work for constructor functions too. 3. Scan rest of codebase for other usages of the type parameters property that should be calls to getEffectiveTypeParameterDeclarations. 4. Rename tp to something more readable, like typar or ts'.
|
CI failed because I missed a fourslash test. It's updated now. |
|
I added support for |
mhegazy
reviewed
Apr 19, 2018
src/compiler/checker.ts
Outdated
| @@ -2060,10 +2061,10 @@ namespace ts { | |||
| let symbol: Symbol; | |||
| if (name.kind === SyntaxKind.Identifier) { | |||
| const message = meaning === namespaceMeaning ? Diagnostics.Cannot_find_namespace_0 : Diagnostics.Cannot_find_name_0; | |||
|
|
|||
| symbol = resolveName(location || name, name.escapedText, meaning, ignoreErrors ? undefined : message, name, /*isUse*/ true); | |||
| const secondarySymbol = resolveEntityNameFromJSPrototype(name, meaning); | |||
There was a problem hiding this comment.
consider adding isInJavascriptFile just for clarity.
There was a problem hiding this comment.
And maybe a comment that says "secondarySymbol is undefined except for type references in jsdoc on javascript prototype assignments"
Or something simpler than that. Hopefully.
mhegazy
approved these changes
Apr 19, 2018
This was referenced Apr 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, classes did not understand the
@templatetag, so there was no way to declare and use type parameters on classes in Javascript.This change makes the checker get the "effective" type parameters for a class, which means that Javascript classes also check their jsdoc for
@templatetags. The rest of the type parameter machinery is unchanged.Edit: this PR now makes type parameters work with constructor functions as well. This required changes in name resolution and class instantiation since type parameters can be looked up outside their scope, and the anonymous type created by newing a Javascript constructor can now be instantiated.
Only the class support is needed to unblock webpack/webpack#7046 and webpack/webpack#7050, however.
Fixes #23459
Fixes #23384
Fixes #23385
Fixes #18135