Flag default imports with named imports as needing importStar #23795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Apr 30, 2018
| @@ -34,7 +34,8 @@ namespace ts { | |||
| } | |||
|
|
|||
| export function getImportNeedsImportStarHelper(node: ImportDeclaration) { | |||
| return !!getNamespaceDeclarationNode(node) || (getNamedImportCount(node) > 1 && containsDefaultReference(node.importClause.namedBindings)); | |||
| const minNamed = isDefaultImport(node) ? 0 : 1; | |||
| return !!getNamespaceDeclarationNode(node) || (getNamedImportCount(node) > minNamed && (!minNamed || containsDefaultReference(node.importClause.namedBindings))); | |||
There was a problem hiding this comment.
this assumes that default will only appear at most once in the named list, but nothing stops you from writing import {default as a, default as b} from "m";. which should be harmless. but worth adding a test.
mhegazy
approved these changes
Apr 30, 2018
|
@mhegazy I've restructured the helper functions a bit and added your testcase, you should re-review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21621