Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-Concept: Excess property checking for nested intersection and union #23798

Closed

Conversation

jack-williams
Copy link
Collaborator

Proof-of-concept excess property checking for nesting intersection and union (independent of discriminant properties). See tests/cases/compiler/nestedExcessPropertyChecks.ts for some examples. Just putting this out there incase it is of interest to anyone.

Please feel free to check it out and have a go, though the error messages are not good and the code is slow and ugly.

@mattmccutchen
Copy link
Contributor

This is intended to fix #13813 and #20863, right? Adding references.

@jack-williams
Copy link
Collaborator Author

Yes thats the aim and currently it does fix those cases.

Though I will stress that I don't intend this PR to be the fix. The issue is not a community milestone and I don't know if it's already being worked on by the TS team. Also, the code is still far away from being in a reviewable state (there is one bug I've found already).

I was mainly just hoping it might be of interest or use to someone. If there is desire to try and integrate it then I'm happy to put more work into it.

@typescript-bot
Copy link
Collaborator

Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants