Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share code between typeReferenceDirectives and referencedFiles parsing #23904

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 4, 2018

Noticed while reviewing #23893

@ghost ghost requested a review from rbuckton May 4, 2018 21:43
@ghost ghost mentioned this pull request May 4, 2018
@sheetalkamat
Copy link
Member

In my opinion, current form is more readable.

@ghost ghost closed this May 7, 2018
@ghost ghost deleted the references branch May 7, 2018 14:58
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant