Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEditsForFileRename: Don't update unrelated import #24961

Merged
3 commits merged into from
Jun 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 14, 2018

Fixes #24914

An import is unrelated if it isn't inside the renamed file, and doesn't import the renamed file.

@ghost ghost requested a review from amcasey June 14, 2018 17:18
@ghost ghost force-pushed the getEditsForFileRename_unrelated branch from 2373d5f to b9bc8f0 Compare June 14, 2018 17:20
@ghost
Copy link
Author

ghost commented Jun 14, 2018

Looks like there is an error after rebasing onto master -- can't really debug it until #24697 is fixed.

@ghost ghost merged commit 7a1d75c into master Jun 14, 2018
@ghost ghost deleted the getEditsForFileRename_unrelated branch June 14, 2018 22:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant