Adds related spans and error grouping for duplicate identifier errors #25328
Conversation
|
What about the ones in the same file, are you going to add the related info to the binder duplicate declaration diagnostics? |
| @@ -0,0 +1,12 @@ | |||
| // @pretty: true | |||
There was a problem hiding this comment.
can we just log the additional info to the .errors baseline. it is nice that we have --pretty tests, but do not think all of the tests should be --pretty tests. they are hard to read really in baseline format.
There was a problem hiding this comment.
it is also good to see how this change affects our existing tests too.
There was a problem hiding this comment.
I should now be recording related info in the error baselines.
src/compiler/diagnosticMessages.json
Outdated
| "category": "Message", | ||
| "code": 6201 | ||
| }, | ||
| "Conflicts here.": { |
There was a problem hiding this comment.
@DanielRosenwasser comments on the messages?
There was a problem hiding this comment.
this is a bit whimsical, but would be nice if it looked like:
file1.ts (1, 2): Error: Duplicate identifier 'foo'.
+ file2.ts (2, 3): "foo" was also declared here.
+ file3.ts (2, 3): and here.There was a problem hiding this comment.
In what output? The error baselines?
There was a problem hiding this comment.
Ohh, i get it, the different messages based on count. Certainly doable.
Fixes #25324
This adds related spans for cross-file "duplicate identifier" type errors (for up to the first 5 related spans, chosen by fair dice roll, as to avoid cluttering the output too much), and also compacts instances where many of such errors appear across a pair of files down to a single error message (the limit having been arbitrarily chosen as 8 instances).
Examples:
