Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple output .d.ts files changedness correctly #25370

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Handle multiple output .d.ts files changedness correctly #25370

merged 2 commits into from
Jul 2, 2018

Conversation

RyanCavanaugh
Copy link
Member

Fixes #25337 and gets rid of a bad type assertion

@mhegazy
Copy link
Contributor

mhegazy commented Jul 2, 2018

We probably need a unit test to cover the scenario in #25337

@RyanCavanaugh
Copy link
Member Author

The new file in the PR tests that scenario

@RyanCavanaugh RyanCavanaugh merged commit c1c4a39 into microsoft:master Jul 2, 2018
@RyanCavanaugh RyanCavanaugh deleted the fix25337 branch July 2, 2018 21:17
@RyanCavanaugh RyanCavanaugh mentioned this pull request Jul 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanCavanaugh @mhegazy