Skip to content

Remove ES2018 transforms for ES2018 target #26315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2019
Merged

Remove ES2018 transforms for ES2018 target #26315

merged 4 commits into from
Feb 6, 2019

Conversation

saschanaz
Copy link
Contributor

Fixes #20463

@DanielRosenwasser
Copy link
Member

Seems like there should be a test to ensure that ES2018 actually preserves these features.

@DanielRosenwasser
Copy link
Member

@rbuckton can you take a look at this PR?

@saschanaz
Copy link
Contributor Author

@DanielRosenwasser Yeah... but where should the test go? Can you point an existing test which can be a guide?

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 17, 2018
rbuckton
rbuckton reviewed Sep 27, 2018
View reviewed changes
@rbuckton rbuckton mentioned this pull request Sep 28, 2018
Merged
@rbuckton
Copy link
Member

@saschanaz: You would likely need to move around some of the tests in tests/cases/conformance to align them with the correct ECMAScript edition.

@saschanaz saschanaz force-pushed the destruct-es2018 branch 3 times, most recently from 3e18658 to fda769d Compare October 27, 2018 05:16
@saschanaz
Copy link
Contributor Author

I fixed the tests for async generator / for-await to correctly target es2018 instead of esnext.

@saschanaz
Copy link
Contributor Author

saschanaz commented Oct 27, 2018 •
edited
Loading

Couldn't replace @lib: esnext yet as it depends on #26220.

@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 6, 2018 •
edited
Loading

So it seems this is blocked again? #28354

@weswigham
Copy link
Member

That's TypeFlags not TransformFlags. Different enum.

@saschanaz
Copy link
Contributor Author

Oops!

@weswigham
Copy link
Member

Ping @rbuckton for review again - this looks pretty done. esnext just being optional catch clause right now is pretty great (sad it didn't make it on the 2018 train, would have made this even easier).

@saschanaz
Copy link
Contributor Author

Rebased with git file rename, now it should be easier to review commit-by-commit.

@fearthecowboy
Copy link
Member

Is this going to make it in 3.3?

@weswigham weswigham merged commit 6249b4c into microsoft:master Feb 6, 2019
@saschanaz saschanaz deleted the destruct-es2018 branch February 7, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton rbuckton approved these changes

Assignees

@rbuckton rbuckton

Labels
None yet
Projects
None yet
Milestone
TypeScript 3.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@saschanaz @DanielRosenwasser @rbuckton @weswigham @fearthecowboy @RyanCavanaugh