-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Support for understanding some JSDoc annotations within JavaScript files. #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
f5eb61a
Add support for parsing JSDoc types.
CyrusNajmabadi 6b51c54
Tests for jsdoc comment parsing.
CyrusNajmabadi 4dba649
Additional test.
CyrusNajmabadi a63e260
Additional jsdoc tests. Simplify test output.
CyrusNajmabadi 803a8e2
Add test for non-nullable type.
CyrusNajmabadi b5dfb0d
Add tests for record types.
CyrusNajmabadi 80803ca
tests for parsing generics.
CyrusNajmabadi bc1659a
Add negative tests for parsing jsdoc types.
CyrusNajmabadi 57e9c94
Add additional negative test.
CyrusNajmabadi c8876b0
Simplify code.
CyrusNajmabadi 8ba61f6
Mark if nodes were parsed from a javascript file or not.
CyrusNajmabadi 50bb499
Support passing a start/length when creating a scanner.
CyrusNajmabadi 604988c
Add support for parsing JSDoc comments.
CyrusNajmabadi 2e58435
Add tests for parsing JSDoc comments.
CyrusNajmabadi 3a33884
Add support for converting JSDoc types to our own types.
CyrusNajmabadi 6292f3e
Add tests for JSDoc comment intellisense.
CyrusNajmabadi 39c8c0d
Add support for function return types in JSDoc comments.
CyrusNajmabadi c8e106e
Don't use a sourceFile if one isn't passed in.
CyrusNajmabadi cef25bf
Only check source file when we have one.
CyrusNajmabadi d886b0f
Rename property. Add walking for jsdoc nodes.
CyrusNajmabadi e8a3d24
Set parent pointers for JSDoc comments.
CyrusNajmabadi d319e86
Remove special casing for nodes without parents now that we are prope…
CyrusNajmabadi 047ac2c
Use actual type parameter nodes in doc comments.
CyrusNajmabadi 0cb45c5
Add support for generic type parameters in JSDoc comments.
CyrusNajmabadi 7ff85b3
Only clear children if they exist.
CyrusNajmabadi 8564a8b
Add support for variadic JSDoc types.
CyrusNajmabadi cd2d5cd
Property show variadic parameters for javascript functions.
CyrusNajmabadi 2cb375a
Share code for getting information about a parameter from a JSDoc com…
CyrusNajmabadi c8d8e0b
Simplify parameter handling code.
CyrusNajmabadi e8e1819
Report error when ... is used in a .js file.
CyrusNajmabadi d1cf715
Merge branch 'master' into jsDocSupport
CyrusNajmabadi e0837f8
Treat JSDoc types as actual Typenodes.
CyrusNajmabadi c4ee838
Use a single getTypeFromTypeNode function for normal types and JSDocT…
CyrusNajmabadi 8622b35
initial support for function types.
CyrusNajmabadi e7f61e6
Add support for JSDoc construct signatures.
CyrusNajmabadi 17d80e7
additional test.
CyrusNajmabadi ed8afa2
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 7d2dd0c
Updating baselines.
CyrusNajmabadi c405e6a
Handle 'returns' inside JSDoc comments
CyrusNajmabadi 6561906
Add support for top level JSDoc union types.
CyrusNajmabadi 6599a4b
Skip whitespace before parsing out a type.
CyrusNajmabadi 49f8a41
Add support for param tags where the type follows the identifier name.
CyrusNajmabadi dcfb932
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 6732e21
Add support for bracketed JSDoc parameter names.
CyrusNajmabadi da256dd
Delete empty test.
CyrusNajmabadi 613bb30
Supported bracketed parameter names with an optional initializer.
CyrusNajmabadi 3e04643
Add support for parsing JSDoc array types.
CyrusNajmabadi f190ac8
Add type checking for JSDoc array types.
CyrusNajmabadi 6c60dad
Add support for parsing nullable/non-nullable types with syntax at th…
CyrusNajmabadi e43fc69
Support arbitrary identifier names as type reference names in JSDoc c…
CyrusNajmabadi 0884fdb
Use undefinedType for JSDoc type results, not 'undefined'
CyrusNajmabadi 2bb5e5a
Add support for tuple types in JSDoc types.
CyrusNajmabadi 96f20da
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 0c8e669
Properly set parents for all js doc nodes.
CyrusNajmabadi dbf6e07
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 6ac6ed8
Simplify initialization/cleanup in the parser.
CyrusNajmabadi 9169acf
Proactively parse out js doc comments for .js files.
CyrusNajmabadi 8645b69
Utilize the core parsing functionality to support parsing JSDoc expre…
CyrusNajmabadi 5544639
Add test for javascript syntactic diagnostics.
CyrusNajmabadi 4840d69
Move binding code back into the binder.
CyrusNajmabadi a9cd568
Fix spacing.
CyrusNajmabadi ab07292
Simplify checker.
CyrusNajmabadi 3710101
Remove unnecessary file.
CyrusNajmabadi 26e94df
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 5e2e77e
Handle binding of JSDocFunctionTypes in a uniform manner with Consruc…
CyrusNajmabadi 9b7cf50
Simplify binding of JSDocFunctionTypes.
CyrusNajmabadi f261ea9
Simplify recursion in the binder. Always go through bindChildren.
CyrusNajmabadi b406d5a
CR feedback.
CyrusNajmabadi ad4a172
CR feedback.
CyrusNajmabadi d4911b7
CR feedback.
CyrusNajmabadi 72495f8
CR feedback.
CyrusNajmabadi 0c83e46
CR feedback.
CyrusNajmabadi 05ffaaf
CR feedback.
CyrusNajmabadi 28c80c3
CR feedback.
CyrusNajmabadi c92c63b
CR feedback.
CyrusNajmabadi 6f2d1b7
CR feedback.
CyrusNajmabadi 7f28fd2
CR feedback.
CyrusNajmabadi 91cc72a
Merge branch 'getTypeFromTypeNode' into jsDocSupport
CyrusNajmabadi a33f703
CR feedback.
CyrusNajmabadi 48a703b
CR feedback.
CyrusNajmabadi 6157ac7
CR feedback.
CyrusNajmabadi 01143cf
CR feedback.
CyrusNajmabadi de5e13c
CR feedback.
CyrusNajmabadi 92f696d
CR feedback.
CyrusNajmabadi 57d01df
Merge branch 'master' into jsDocSupport
CyrusNajmabadi da04504
Merge branch 'getTypeFromTypeNode' into jsDocSupport
CyrusNajmabadi 95ca000
Merge branch 'master' into jsDocSupport
CyrusNajmabadi a3f3baa
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 64b9792
Remove code.
CyrusNajmabadi 580db27
Merge branch 'master' into jsDocSupport
CyrusNajmabadi d76f415
Type JSDocRecordMembers to look like PropertyDeclarations.
CyrusNajmabadi 316d25c
Add support for object literals in JSDoc comments.
CyrusNajmabadi 548aa85
Add support for 'this-types' from JSDoc comments.
CyrusNajmabadi a6a57c2
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 393eaa1
Get all members of the types of a union type for javascript completions.
CyrusNajmabadi 6d186cb
Merge branch 'master' into jsDocSupport
CyrusNajmabadi f1d1a66
PR feedback.
CyrusNajmabadi 43c1796
Rename type.
CyrusNajmabadi b16be6c
Represent jsdoc comments in the tree as an actual node.
CyrusNajmabadi fea1485
Properly set pos/end on template tags.
CyrusNajmabadi 48a6554
Remove the JSDocCommentInfo type. It's only used for testing now.
CyrusNajmabadi 507caf7
Remove the JSDocCommentInfo temporary type.
CyrusNajmabadi f915d6f
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 5d6a1e8
Use real type nodes for primitive types.
CyrusNajmabadi 47ad2f5
Add support for classifying jsdoc comments
CyrusNajmabadi f505486
Merge branch 'master' into jsDocSupport
CyrusNajmabadi fdc9ba1
use pos/end instead of width()
CyrusNajmabadi 3b656e8
Deal properly with type parameters not parented by signatures/classes…
CyrusNajmabadi b3e75b0
Merge branch 'master' into jsDocSupport
CyrusNajmabadi ab44f95
Support @type tags referencing JS values.
CyrusNajmabadi 169e631
Merge branch 'master' into jsDocSupport
CyrusNajmabadi df73f4f
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 30cf902
Merge branch 'master' into jsDocSupport
CyrusNajmabadi c3b3d39
Merge branch 'master' into jsDocSupport
CyrusNajmabadi daeed1b
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 864525a
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 729c96c
Move code.
CyrusNajmabadi 0e23b04
Merge branch 'master' into jsDocSupport
CyrusNajmabadi c0e61b8
Merge branch 'master' into jsDocSupport
CyrusNajmabadi feec07c
Merge branch 'master' into jsDocSupport
CyrusNajmabadi d8ef02a
Added non-ts file support to the server
billti 1725e9f
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 34c128e
Added JSX support
billti 74914a5
Merge branch 'master' into jsDocSupport
CyrusNajmabadi c8d2553
Merge branch 'master' into jsDocSupport
CyrusNajmabadi 6e8a8e6
Merge branch 'master' into jsDocSupport
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OR?