Get [type] parameter types from @type tag #26694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the return type was used in cases like this: ```js /** @type {<T>(param?: T) => T | undefined} */ function g(param) { return param; } ``` Now the type parameters from the type tag are used, and the compiler gets the type of the parameter by using the position in the signature of the type tag. Fixes #25618
ghost
approved these changes
Aug 27, 2018
src/compiler/utilities.ts
Outdated
| } | ||
| const typeTag = getJSDocType(node); | ||
| if (typeTag) { | ||
| if (isFunctionTypeNode(typeTag) && typeTag.typeParameters) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the return type was used in cases like this:
Now the type parameters from the type tag are used, and the compiler gets the type of the parameter by using the position in the signature of the type tag.
Note that this isn't the most complete fix — it only works for function types written directly in the type tag, not type references. However, I don't think that's very common, so I'd prefer to wait until I have evidence that it is. (I believe that supporting arbitrary references would require quite a bit more code.)
Fixes #25618