Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add related span pointing at missing arguments #27013

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Add related span pointing at missing arguments #27013

merged 1 commit into from
Sep 10, 2018

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Sep 10, 2018 •
edited
Loading

image

Fixes #25255

@weswigham
Copy link
Member Author

cc @DanielRosenwasser

@DanielRosenwasser
Copy link
Member

Maybe instead of guessing for closest signatures we should only do this for one signature, but let's experiment a bit. 👍

@weswigham weswigham merged commit e9c6d96 into microsoft:master Sep 10, 2018
@weswigham weswigham deleted the related-span-argument-count branch September 10, 2018 23:40
@sandersn sandersn mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @DanielRosenwasser