Make RenameInfo a union #27382
Merged
Make RenameInfo a union #27382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
renameInfoUnion
branch
from
3efc14b to
17570a6
Compare
ghost
force-pushed
the
renameInfoUnion
branch
from
17570a6 to
9f967c8
Compare
sheetalkamat
approved these changes
Sep 27, 2018
ghost
pushed a commit
that referenced
this pull request
Sep 27, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 11, 2018
mrcrane
pushed a commit
to mrcrane/TypeScript
that referenced
this pull request
Jul 26, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27373
Separates
RenameInfoSuccessandRenameInfoFailure. PreviouslyRenameInfocontained their combined properties -- marked non-optional but we were passingundefined!to them (was a TODO for #18217).This will technically be a type-level breaking change, but shouldn't be a breaking change at runtime.