Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test for update spec section 4.9.3 contextual typing in function expression #2761

Merged
merged 9 commits into from
May 4, 2015

Conversation

yuit
Copy link
Contributor

@yuit yuit commented Apr 14, 2015

Conformance in update spec section 4.9.3 PR #1878

@DanielRosenwasser
Copy link
Member

Don't use the name functionExpressionContextualTyping if you're immediately going to make version 1 after. Just do functionExpressionContextualTyping01.ts and functionExpressionContextualTyping02.ts

@yuit yuit changed the title Conformance test for update incontextual type in function expression Conformance test for update contextual typing in function expression Apr 14, 2015
var g: ((s: string, w: boolean) => void) | ((n: number) => number);
var g1: ((s: string, w: boolean) => void) | ((s: string, w: number) => string);

g1 = (j, m) => { } // Per spec, no contextual signature can be extracted in this case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain why no signature can be extracted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain that no signature can be extracted "in the following cases".

@yuit yuit changed the title Conformance test for update contextual typing in function expression Conformance test for update spec section 4.9.3 contextual typing in function expression Apr 16, 2015
yuit added a commit that referenced this pull request May 4, 2015
…uncExp

Conformance test for update spec section 4.9.3 contextual typing in function expression
@yuit yuit merged commit 3da1315 into master May 4, 2015
@yuit yuit deleted the conformanceContextuallyTypedFuncExp branch May 4, 2015 17:48
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants