Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test spec change in section 4.17.1 destructuring assignment and 5.1.2 variable declaration conformance tests #2773

Merged
merged 4 commits into from
May 4, 2015

Conversation

yuit
Copy link
Contributor

@yuit yuit commented Apr 15, 2015

Conformance for spec change 4.17.1, 5.1.2 See

@DanielRosenwasser DanielRosenwasser changed the title Destructuring assignment and variable declaration Destructuring assignment and variable declaration conformance tests Apr 15, 2015
@DanielRosenwasser
Copy link
Member

While it's not valid, it would certainly be useful to have tests for binding pattern variable declarations with no initializers as we discussed today.

~~~~~
!!! error TS2461: Type 'undefined' is not an array type.
~~~~~~~~~
!!! error TS2461: Type 'undefined' is not an array type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? I always forget whether or not we display the undefined type in errors.

@yuit yuit changed the title Destructuring assignment and variable declaration conformance tests Conformance destructuring assignment and variable declaration conformance tests Apr 16, 2015
@yuit yuit changed the title Conformance destructuring assignment and variable declaration conformance tests Conformance test spec change in section 4.17.1 destructuring assignment and 5.1.2 variable declaration conformance tests Apr 16, 2015
yuit added a commit that referenced this pull request May 4, 2015
…nment

Conformance test spec change in section 4.17.1 destructuring assignment and 5.1.2 variable declaration conformance tests
@yuit yuit merged commit 75c0bbc into master May 4, 2015
@yuit yuit deleted the conformanceDestructuringAssignment branch May 4, 2015 17:48
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants