Let ts-ignore ignore suggestions

[sandersn]

Having checkJs on a JS file can potentially create many suggestions. One of the suggested codefixes is "add // @ts-ignore", but this does nothing. Making ts-ignore work with suggestions is one fix.

Two others are

1. Do not suggest ts-ignore for suggestions.
2. Allow (VS Code?) users to selectively turn off specific errors.

Of course, there is

3. Do nothing. The small suggestion … isn't that intrusive and (currently) is explicitly requested by checkJs users, who will not be bothered by the bogus ts-ignore suggestion.

[sandersn]

Not suggesting ts-ignore looks pretty hard; I followed the trail back to CodeFixRequestArgs in protocol.ts; it only provides a list of errorCodes, but not whether they originated from a suggestion or an error.

[sandersn]

Yep, after consulting with @sheetalkamat, it looks like changing CodeFixRequestArgs requires a change in VS Code as well. I'll bring this up next time we meet.

[ghost]

This should probably wait on #19139. We don't want people adding // @ts-ignore to disable a suggestion and missing out on actual errors.

[sandersn]

I agree; in any case I think not suggesting ts-ignore is the better option since preliminary evidence [1] suggests that the noImplicitAny suggestions are not that obtrusive.

[1] that is, talking to @uniqueiniquity, who has been using the new suggestions.