Skip to content

Improve error message when comparing non-comparable types #28023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Improve error message when comparing non-comparable types #28023

wants to merge 3 commits into from

Conversation

tony-ho
Copy link

@tony-ho tony-ho commented Oct 21, 2018

Fixes #27910

@msftclas
Copy link

msftclas commented Oct 21, 2018

CLA assistant check
All CLA requirements met.

@RyanCavanaugh
Copy link
Member

@DanielRosenwasser are you good with this verbiage as-is?

@RyanCavanaugh RyanCavanaugh self-assigned this Jan 8, 2020
@RyanCavanaugh
Copy link
Member

I'll rebase this. We also decided to not explicitly recommend unknown since a tighter lower bound (such as string or boolean) is often more appropriate.

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2020
@sandersn
Copy link
Member

sandersn commented Mar 5, 2020

@RyanCavanaugh do you just want that sentence removed from the error?

@sandersn
Copy link
Member

Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs.

@sandersn sandersn closed this May 24, 2022
@tony-ho tony-ho deleted the errorMessageNonComparableTypes branch May 30, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
5 participants