-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurePlugins command for tsserver #28106
configurePlugins command for tsserver #28106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API changes for server and plugins look good! Just let me know how you want us to expose this on the VS Code side
@mjbvz Thanks! Just opened corresponding PR microsoft/vscode#61756 , let me know if that works. |
Changes look good but we need test. |
Thanks |
2dd7960
to
2e4fe43
Compare
@sheetalkamat test added! |
2e4fe43
to
db914d8
Compare
Build failed with api |
configurePlugins command for tsserver
Merge pull request #28106 from minestarks/configure-plugins
Implements #18604
configurePlugins
.PluginModule
,onConfigurationChanged
. Plugin authors can implement this.configurePlugins
is invoked, it will pass on the configuration object to any loaded plugin instances with a matching name.create
/PluginCreateInfo
as well as any previous configurations passed in inconfigurePlugins
.create
call, to any projects loaded in the future with the matching plugin. This is needed for consistency -- the caller ofconfigurePlugins
would have no way of knowing whether the plugin/project of interest has yet been loaded.cc @mjbvz