infer-from-usage suggestions can't be ignored, and always do something when invoked. #28206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to write tests.
|
Note that we should do this for unused locals and unused parameters errors as well, since they also can't be ts-ignored, but offer it nonetheless. |
ghost
approved these changes
Oct 29, 2018
| const type = inferTypeForVariableFromUsage(setAccessorDeclaration.name, program, cancellationToken) || | ||
| inferTypeForVariableFromUsage(param.name, program, cancellationToken); | ||
| let type = inferTypeForVariableFromUsage(setAccessorDeclaration.name, program, cancellationToken); | ||
| if (type === program.getTypeChecker().getAnyType()) { |
There was a problem hiding this comment.
Would it be better to use type.flags & TypeFlags.Any here?
There was a problem hiding this comment.
Short answer: no.
Long answer: here we are checking for exactly the fallback type produced inside inferFromUsage.ts, not other types that come from the checker like errorType. Those types are already filtered out in addCandidateType, which does use TypeFlags.Any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ts-ignore codefix does not apply to suggestions, so I made separate implicit any suggestions.
Based on our discussion with VS Code, and with @bterlson. I agree that invoking a suggestion and having nothing happen feels like a bug, which is worse than inferring a useless
any.