Make Number and String literal types immutable. #28344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested changes
Nov 5, 2018
| @@ -21820,10 +21829,18 @@ namespace ts { | |||
|
|
|||
| function checkBinaryLikeExpression(left: Expression, operatorToken: Node, right: Expression, checkMode?: CheckMode, errorNode?: Node): Type { | |||
| const operator = operatorToken.kind; | |||
| let leftType: Type; | |||
|
|
|||
| const symbol = (<Identifier>left).escapedText ? getResolvedSymbol(left as Identifier) : undefined; | |||
There was a problem hiding this comment.
Use isEntityNameExpression and not left.escapedText (since checking a.b += 1 is also desireable. Also, a test for a.b += 1 would be good.
src/compiler/checker.ts
Outdated
| @@ -21465,7 +21465,16 @@ namespace ts { | |||
| } | |||
|
|
|||
| function checkPostfixUnaryExpression(node: PostfixUnaryExpression): Type { | |||
| const operandType = checkExpression(node.operand); | |||
| let operandType: Type; | |||
| const symbol = (<Identifier>node.operand).escapedText ? getResolvedSymbol(node.operand as Identifier) : undefined; | |||
There was a problem hiding this comment.
Use isEntityNameExpression and not left.operand.escapedText (since checking a.b++ is also desirable. Also, a test for a.b++ would be good.
collin5
force-pushed
the
b14745
branch
2 times, most recently
from
a1dd0ae
to
56817c8
Compare
|
@weswigham Thank you! Addressed the feedback. Also added more tests for both |
weswigham
added
Suggestion
RyanCavanaugh
removed
In Discussion
|
No worries. Thanks for the update 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14745