-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es3.d.ts #28372
Add es3.d.ts #28372
Conversation
Am I missing something or is the current setup one that would have an Unless I'm missing something, the current |
@ericdrobinson The OP says:
Moving all in once is doable but generates tons of baseline changes, which will make this PR hard to review. I want to get some review about code changes first and then move remaining types. |
thanks to fourslash library chain tracking
In the intervening years since #2410 was logged, pretty much all the ES3 targets have died out (even the use cases identified most recently don't even really count as a true ES3 target). Something we should have realized four years ago was that this would be a breaking change! Anyone targeting ES3 but using ES5 APIs (which is an entirely reasonable state to find yourself in if your actual runtime is ES5 and you're not using getters/setters, or if you're using polyfills) is going to be broken if we merge this and make So given the relative lack of remaining use cases for this, and the fact that to preserve back compat we'd have to make this an opt-in that you can effectively already achieve today with |
@RyanCavanaugh FYI Salesforce Marketing Cloud is using an ES3 compatible language set for (Jint is their JS runtime) their SSJS language. |
Revives #16077
Fixes #2410
Fixes #15978
Intentionally included only NaN in es3.d.ts to initially generate minimal baseline changes.