Add perf optimizations for path comparisons #28645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weswigham: Can you take a look at this change today? Without the caching in #28629, this was a major performance bottleneck, so I can definitely see it coming back as an issue at some point in the future. |
weswigham
approved these changes
Nov 26, 2018
rbuckton
commented
Nov 26, 2018
| @@ -6925,7 +6925,7 @@ namespace ts { | |||
|
|
|||
| export interface ObjectAllocator { | |||
| getNodeConstructor(): new (kind: SyntaxKind, pos?: number, end?: number) => Node; | |||
| getTokenConstructor(): new <TKind extends SyntaxKind>(kind: TKind, pos?: number, end?: number) => Token<TKind>; | |||
| getTokenConstructor(): { new <TKind extends SyntaxKind>(kind: TKind, pos?: number, end?: number): Token<TKind> }; | |||
There was a problem hiding this comment.
NOTE: this just fixes coloration in the file. There seems to be a bug in the TypeScript syntax highlighting here.
There was a problem hiding this comment.
Filed as a bug here: microsoft/TypeScript-TmLanguage#687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few minor changes to improve the performance of path comparisons.
Prior to #28629, this change shaved about 60 seconds off of the owa controls build time, though following #28629 this only saves about 2 seconds.