Release-1.5: Add a common, dense, format for classification operations to lower cost of processing on the host side. #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st of processing on the host side.
We now just return an array of triples to represent classified results. The triple contains:
1) the start of the classification.
2) the length of the classification.
3) the type of the clasification.
We also encode this into a comma separated string when passing over to the managed side
(as opposed to an JSON array). That way we don't pay such a high JSON parsing cost.
Instead, we can just do a string.split(",") on the encoded triples and process each
element ourselves.
CyrusNajmabadi
changed the title
CyrusNajmabadi
added a commit
that referenced
this pull request
May 1, 2015
Release-1.5: Add a common, dense, format for classification operations to lower cost of processing on the host side.
| @@ -235,6 +235,9 @@ module Harness.LanguageService { | |||
| class ClassifierShimProxy implements ts.Classifier { | |||
| constructor(private shim: ts.ClassifierShim) { | |||
| } | |||
| getEncodedLexicalClassifications(text: string, lexState: ts.EndOfLineState, classifyKeywordsInGenerics?: boolean): ts.Classifications { | |||
| throw new Error("NYI"); | |||
There was a problem hiding this comment.
why is this not implemented?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work to port this change to release-1.5
Add a common, dense, format for classification operations to lower cost of processing on the host side.
We now just return an array of triples to represent classified results. The triple contains:
We also encode this into a comma separated string when passing over to the managed side
(as opposed to an JSON array). That way we don't pay such a high JSON parsing cost.
Instead, we can just do a string.split(",") on the encoded triples and process each
element ourselves.
The existing APIs remain for back-compat. But they will be removed in the future once all clients have moved to the new API.