Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27070 and #18459.
Right now, inlining only works within a file, because I need to do all the checking beforehand in the
getAvailableActions
function. I fear that if I were to search the whole project, I would violate the performance requirement ofgetAvailableActions
in case of large projects.Both Inline function and Inline local work the same:
Depending on some conditions in the
canInline
function, the refactoring may not be available. The user does not get feedback on why, though. I opened a related issue #28410, which adds reporting for refactorings to the tsserver interface, but it has not been implemented, yet.