Use EmitAndSemanticDiagnosticsBuilder in builder from tsc #30404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
rbuckton,
DanielRosenwasser,
RyanCavanaugh,
sandersn and
weswigham
sandersn
requested changes
Mar 14, 2019
|
Cant write test as this is invocation of API from tsc.js. It fixes the issue of ".tsbuildinfo" not written because abstract builder doesn't have any incremental compilation information. |
sandersn
approved these changes
Mar 14, 2019
|
as I just said in the #30412 I still have problems with :'--tsBuildInfoFile'. I hope Script kiddie dont mean lamer for every one because I am the proudest skid' in the world since I have edited my commit comment all in JSON (I wont be noob forever it will pass with time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.