Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableImportOptimizations compiler option #30766

Closed
wants to merge 3 commits into from
Closed

Add disableImportOptimizations compiler option #30766

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2019

Adds new compiler option disableImportOptimizations to disable import optimizations (removal) as discussed in #9191.

@msftclas
Copy link

msftclas commented Apr 5, 2019

CLA assistant check
All CLA requirements met.

@RyanCavanaugh
Copy link
Member

We're unable to accept PRs for Suggestions tagged In Discussion - please see the PR template. Thanks!

@ghost
Copy link
Author

ghost commented Apr 26, 2019

@RyanCavanaugh How about you guys provide us an adequate solution then? The issue is almost 3 years old.

@marcj
Copy link

marcj commented May 4, 2019

@raphaelhittich, cool! Could you fork TypeScript and publish your version on npm?
Removing unused imports that have side-effects (like decorators on a class that registers itself in a global context) it literally one of the biggest DX breaker of TS, so I guess a lot of people would use your fork if they need such a solution. Forking is the only option if Microsoft thinks they know it better. Maybe we can fix then also the whole nominal type and runtime reflection disaster.
I can support you with time and $, if you need any help. Maybe it makes sense to create a patreon then as I think a lot of people/projects will use it since it's really a game changer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants