Skip to content

feat: Implement the implicitUnknown complier flag #30813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Apr 8, 2019

See #27265 for details.

I have no idea if I’ve actually implemented this correctly or not.

To do list:

  • Ensure that generated .d.ts contain unknown where implicit any would have been previously.
  • Test that explicit any still works correctly.
  • Figure out how the tests work in this.

/cc @Andy-MS, @mmkal, @RyanCavanaugh

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@ExE-Boss ExE-Boss force-pushed the compiler/flags/implicit-unknown branch 2 times, most recently from 5d0f70b to 18bc659 Compare April 8, 2019 16:43
@DanielRosenwasser DanielRosenwasser added the Experiment A fork with an experimental idea which might not make it into master label Apr 10, 2019
@sandersn
Copy link
Member

This experiment is pretty old, so I'm going to close it to reduce the number of open PRs.

@sandersn sandersn closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experiment A fork with an experimental idea which might not make it into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants