Skip to content

fix parse error for arrow function in rhs #31110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix parse error for arrow function in rhs #31110

wants to merge 3 commits into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Apr 25, 2019

Fixes #25898

DanielRosenwasser
DanielRosenwasser reviewed Apr 25, 2019
View reviewed changes
src/compiler/parser.ts Outdated
parseErrorAtPosition(start, node.end - start, message, arg0)
}

function isStartOfSimpleArrowFunction () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray space

@Kingwl
Copy link
Contributor Author

Kingwl commented Apr 26, 2019

@typescript-bot test this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2019 •
edited
Loading

Heya @Kingwl, I've started to run the extended test suite on this PR at b272bca. You can monitor the build here. It should now contribute to this PR's status checks.

@Kingwl Kingwl closed this May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve errors for potential arrow functions
3 participants
@Kingwl @typescript-bot @DanielRosenwasser