add support for extract as interface #31644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆙 |
|
🙋🏻♂️ |
I think it’s ok to leave this out, but I’d prefer to bail and not offer the fix when you encounter a duplicate member. It’s less-than-ideal to generate invalid code that’s not another codefix away from being right:
|
andrewbranch
approved these changes
Aug 27, 2019
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
* add support for extract as interface * fix action assert * Donot provide convert to interface if duplicate member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31640
This pr add another refactor action 'extract to interface', that could extract type literal as an interface, that works within the following case:
I think we should disallow named object types, and type references. that seems overkill
unsupported: