Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct outline hint spans for functions #31865

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jun 12, 2019

The hint span is the range shown in the preview for a collapsed region. We were showing one element too high up the tree.

@amcasey
Copy link
Member Author

amcasey commented Jun 12, 2019

@RyanCavanaugh We're still confirming, but we think this bug may be seriously degrading scrolling perf in large files in VS.

@gundermanc
Copy link
Member

I can confirm on a test sample that this fixes a visual issue in the placement of structure guides.

@uniqueiniquity uniqueiniquity merged commit 0628adc into microsoft:master Jun 12, 2019
@amcasey amcasey deleted the FunctionHintSpan branch June 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants