Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Proposal: If there’s a package.json, only auto-import things in it" #32448

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Revert "Proposal: If there’s a package.json, only auto-import things in it" #32448

merged 1 commit into from
Jul 17, 2019

Conversation

andrewbranch
Copy link
Member

Reverts #31893

See #32441—this apparently needs some perf work for large projects 😬

@andrewbranch andrewbranch mentioned this pull request Jul 17, 2019
Closed
@andrewbranch
Copy link
Member Author 

[17:38:28] Linting: node node_modules/tslint/bin/tslint --project src/tsconfig-base.json --formatters-dir ./built/local/tslint/formatters --format autolinkableStylish
[17:38:28] > /opt/hostedtoolcache/node/10.16.0/x64/bin/node node_modules/tslint/bin/tslint --project src/tsconfig-base.json --formatters-dir ./built/local/tslint/formatters --format autolinkableStylish

/home/vsts/work/1/s/src/compiler/emitter.ts
ERROR: /home/vsts/work/1/s/src/compiler/emitter.ts:414:40 no-unnecessary-type-assertion This assertion is unnecessary since it does not change the type of the expression.

This is failing in master too.

weswigham
weswigham approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve your revert, but y'all should see if you can fix the perf issue promptly and get it back in - hopefully it is just a lack of resolution caching, which should be fixable with some caching hosts that already exist within the compiler~

@andrewbranch
Copy link
Member Author

Thanks @weswigham, I really hope to—I’m leading with reverting because I’m just trying to stay afloat with DefinitelyTyped this week, and I didn’t want our beta release to have this regression in it.

@andrewbranch andrewbranch merged commit 387c917 into microsoft:master Jul 17, 2019
@andrewbranch andrewbranch deleted the revert-31893-enhancement/only-import-from-package-json branch July 17, 2019 21:02
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.6

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jul 17, 2019
@andrewbranch @typescript-bot
Cherry-pick PR microsoft#32448 into release-3.6
edfe806 
Component commits:
f6cb90a Revert "Proposal: If there’s a package.json, only auto-import things in it, more or less (microsoft#31893)"
This reverts commit 60a1b1d.
@typescript-bot typescript-bot mentioned this pull request Jul 17, 2019
Closed
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #32456 for you.

DanielRosenwasser pushed a commit that referenced this pull request Jul 18, 2019
@andrewbranch @DanielRosenwasser
Revert "Proposal: If there’s a package.json, only auto-import things …
47cbe87 
…in it, more or less (#31893)" (#32448)

This reverts commit 60a1b1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@uniqueiniquity uniqueiniquity Awaiting requested review from uniqueiniquity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewbranch @DanielRosenwasser @typescript-bot @weswigham