Added errorCount to WatchStatusReporter to detect 2 or more errors #33082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sheetalkamat
requested changes
Aug 26, 2019
sheetalkamat
approved these changes
Aug 27, 2019
|
@fr3shw3b quick question—in what scenario will |
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
…icrosoft#33082) * Added errorCount to WatchStatusReporter discern between 0 and 2 or more errors * Added test for ensuring WatchStatusReporter receives errorCount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an api improvement to compiler watch functionality that allows distinguishing between 0 and 2 or more errors in a watch status reporter.
Fixes #32542
Have spent some time trying to gauge how to unit test the change for the watch api but couldn't find a clear and obvious place to put it.