Fix #32809 #33199
Merged
Fix #32809 #33199
+89
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-williams
force-pushed
the
fix-32809
branch
from
4080d2b to
a82bd5b
Compare
jack-williams
force-pushed
the
fix-32809
branch
from
a82bd5b to
630499e
Compare
|
OK, yep, I think I grok all this and it looks good to me. 👍 Thanks Jack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32809
With this PR
voidvariables are now assumed to be initialised, removing the possibility of used for assigned errors.To assume a
voidvariable is always assigned is nonsensical, but it's even more nonsensical to report errors based on whether it has, or has not, been assigned to.This has the consequence that
voidis no longer narrowed under inequality.