-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open bigger set of configured projects when opening composite project for operations that operate over multiple projects like rename #33287
Conversation
@typescript-bot pack this |
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at e3de872. You can monitor the build here. It should now contribute to this PR's status checks. |
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running |
422f2b5
to
9b421e8
Compare
LGTM with some name comments |
What does this change imply? Are operations like rename more accurate now? |
This means in our projects setup if you just opened utilities file from |
I just ran into this problem today. How lovely to see that it's already solved. Thank you for working on this! I was wondering, what release of typescript will this be a part of? I can't seem to find any relevant info |
It should be in 3.8 beta |
Does this resolve #30823? |
I was linked to #30823 from microsoft/vscode#80423 and microsoft/vscode#80438. I just tested both of the above issues with 3.8 RC. microsoft/vscode#80438 seems to be fixed, but the issue I described in microsoft/vscode#80423 still remains. |
#28261 on top of #32028