Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up some of the ignore files, and removing the create language service script #33684

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Fix up some of the ignore files, and removing the create language service script #33684

merged 2 commits into from
Nov 6, 2019

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 30, 2019

Fixes some offline feedback from #33584

weswigham
weswigham requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripts/configureTSCBuild.js line in the .dockerignore can also be removed, since that got renamed.

@orta
Copy link
Contributor Author

orta commented Nov 5, 2019

Alright, that's a really delayed fix of the PR

@orta orta merged commit b9fe84e into microsoft:master Nov 6, 2019
@jakebailey jakebailey mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@weswigham weswigham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orta @weswigham