Update DOM from TSJS-lib-generator #33753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps generated bindings to include microsoft/TypeScript-DOM-lib-generator#767. Note that other related APIs were already updated in microsoft/TypeScript-DOM-lib-generator#755 and microsoft/TypeScript-DOM-lib-generator#756 and included in current TypeScript beta. Unfortunately, this one slipped under the radar, but it would be really great to include these changes in beta too for consistency between different WebAssembly methods.
|
It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TSJS-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed. |
|
sigh @sandersn @DanielRosenwasser @orta can you reopen this please? I did copy these files from TSJS-lib-generator, and made a PR here as suggested before, to get changes into TypeScript in time. |
|
Adding @RyanCavanaugh. This is technically breaking, but I would guess it would be relatively limited in impact for 3.7 RC. |
|
@DanielRosenwasser Thanks! |
sandersn
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps generated bindings to include microsoft/TypeScript-DOM-lib-generator#767.
Note that other related APIs were already updated in microsoft/TypeScript-DOM-lib-generator#755 and microsoft/TypeScript-DOM-lib-generator#756 and included in current TypeScript beta.
Unfortunately, this one slipped under the radar, but it would be really great to include these changes in beta too for consistency between different WebAssembly methods.