Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include *.json in the root files if they are specified as root #34676

Merged
merged 1 commit into from
Oct 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/services/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -953,9 +953,7 @@ namespace ts {
names.push(entry);
}
else {
if (entry.scriptKind !== ScriptKind.JSON) {
names.push(entry.hostFileName);
}
names.push(entry.hostFileName);
}
});
return names;
Expand Down
72 changes: 72 additions & 0 deletions src/testRunner/unittests/tsserver/projectErrors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -861,4 +861,76 @@ declare module '@custom/plugin' {
]);
});
});

describe("unittests:: tsserver:: Project Errors with resolveJsonModule", () => {
function createSessionForTest({ include }: { include: readonly string[]; }) {
const test: File = {
path: `${projectRoot}/src/test.ts`,
content: `import * as blabla from "./blabla.json";
declare var console: any;
console.log(blabla);`
};
const blabla: File = {
path: `${projectRoot}/src/blabla.json`,
content: "{}"
};
const tsconfig: File = {
path: `${projectRoot}/tsconfig.json`,
content: JSON.stringify({
compilerOptions: {
resolveJsonModule: true,
composite: true
},
include
})
};

const host = createServerHost([test, blabla, libFile, tsconfig]);
const session = createSession(host, { canUseEvents: true });
openFilesForSession([test], session);
return { host, session, test, blabla, tsconfig };
}

it("should not report incorrect error when json is root file found by tsconfig", () => {
const { host, session, test } = createSessionForTest({
include: ["./src/*.ts", "./src/*.json"]
});
verifyGetErrRequest({
session,
host,
expected: [
{
file: test,
syntax: [],
semantic: [],
suggestion: []
}
]
});
});

it("should report error when json is not root file found by tsconfig", () => {
const { host, session, test, blabla, tsconfig } = createSessionForTest({
include: ["./src/*.ts"]
});
const span = protocolTextSpanFromSubstring(test.content, `"./blabla.json"`);
verifyGetErrRequest({
session,
host,
expected: [{
file: test,
syntax: [],
semantic: [
createDiagnostic(
span.start,
span.end,
Diagnostics.File_0_is_not_listed_within_the_file_list_of_project_1_Projects_must_list_all_files_or_use_an_include_pattern,
[blabla.path, tsconfig.path]
)
],
suggestion: []
}]
});
});
});
}