Add link to documentation in tsconfig.json template generated by tsc --init #34686
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,66 +1,69 @@ | ||
| { | ||
| "compilerOptions": { | ||
| /* Visit https://aka.ms/tsconfig.json to read more about this file */ | ||
|
|
||
| /* Basic Options */ | ||
|
There was a problem hiding this comment. Example shows the comments as not removed #37361 (comment) @RyanCavanaugh @DanielRosenwasser Whats the final call on that |
||
| // "incremental": true, | ||
| // "incremental": true, | ||
| "target": "es5", | ||
| "module": "commonjs", | ||
| // "lib": [], | ||
| // "allowJs": true, | ||
| // "checkJs": true, | ||
| // "jsx": "preserve", | ||
| // "declaration": true, | ||
| // "declarationMap": true, | ||
| // "sourceMap": true, | ||
| // "outFile": "./", | ||
| // "outDir": "./", | ||
| // "rootDir": "./", | ||
| // "composite": true, | ||
| // "tsBuildInfoFile": "./", | ||
| // "removeComments": true, | ||
| // "noEmit": true, | ||
| // "importHelpers": true, | ||
| // "downlevelIteration": true, | ||
| // "isolatedModules": true, | ||
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true, | ||
| // "noImplicitAny": true, | ||
| // "strictNullChecks": true, | ||
| // "strictFunctionTypes": true, | ||
| // "strictBindCallApply": true, | ||
| // "strictPropertyInitialization": true, | ||
| // "noImplicitThis": true, | ||
| // "alwaysStrict": true, | ||
|
|
||
| /* Additional Checks */ | ||
| // "noUnusedLocals": true, | ||
| // "noUnusedParameters": true, | ||
| // "noImplicitReturns": true, | ||
| // "noFallthroughCasesInSwitch": true, | ||
|
|
||
| /* Module Resolution Options */ | ||
| // "moduleResolution": "node", | ||
| // "baseUrl": "./", | ||
| // "paths": {}, | ||
| // "rootDirs": [], | ||
| // "typeRoots": [], | ||
| // "types": [], | ||
| // "allowSyntheticDefaultImports": true, | ||
| "esModuleInterop": true, | ||
| // "preserveSymlinks": true, | ||
| // "allowUmdGlobalAccess": true, | ||
|
|
||
| /* Source Map Options */ | ||
| // "sourceRoot": "", | ||
| // "mapRoot": "", | ||
| // "inlineSourceMap": true, | ||
| // "inlineSources": true, | ||
|
|
||
| /* Experimental Options */ | ||
| // "experimentalDecorators": true, | ||
| // "emitDecoratorMetadata": true, | ||
|
|
||
| /* Advanced Options */ | ||
| "forceConsistentCasingInFileNames": true | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,69 +1,72 @@ | ||
| { | ||
| "compilerOptions": { | ||
| /* Visit https://aka.ms/tsconfig.json to read more about this file */ | ||
|
|
||
| /* Basic Options */ | ||
| // "incremental": true, | ||
| // "incremental": true, | ||
| "target": "es5", | ||
| "module": "commonjs", | ||
| // "lib": [], | ||
| // "allowJs": true, | ||
| // "checkJs": true, | ||
| // "jsx": "preserve", | ||
| "declaration": true, | ||
| // "declarationMap": true, | ||
| // "sourceMap": true, | ||
| // "outFile": "./", | ||
| // "outDir": "./", | ||
| // "rootDir": "./", | ||
| // "composite": true, | ||
| // "tsBuildInfoFile": "./", | ||
| // "removeComments": true, | ||
| // "noEmit": true, | ||
| // "importHelpers": true, | ||
| // "downlevelIteration": true, | ||
| // "isolatedModules": true, | ||
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true, | ||
| // "noImplicitAny": true, | ||
| // "strictNullChecks": true, | ||
| // "strictFunctionTypes": true, | ||
| // "strictBindCallApply": true, | ||
| // "strictPropertyInitialization": true, | ||
| // "noImplicitThis": true, | ||
| // "alwaysStrict": true, | ||
|
|
||
| /* Additional Checks */ | ||
| // "noUnusedLocals": true, | ||
| // "noUnusedParameters": true, | ||
| // "noImplicitReturns": true, | ||
| // "noFallthroughCasesInSwitch": true, | ||
|
|
||
| /* Module Resolution Options */ | ||
| // "moduleResolution": "node", | ||
| // "baseUrl": "./", | ||
| // "paths": {}, | ||
| // "rootDirs": [], | ||
| // "typeRoots": [], | ||
| // "types": [], | ||
| // "allowSyntheticDefaultImports": true, | ||
| "esModuleInterop": true, | ||
| // "preserveSymlinks": true, | ||
| // "allowUmdGlobalAccess": true, | ||
|
|
||
| /* Source Map Options */ | ||
| // "sourceRoot": "", | ||
| // "mapRoot": "", | ||
| // "inlineSourceMap": true, | ||
| // "inlineSources": true, | ||
|
|
||
| /* Experimental Options */ | ||
| // "experimentalDecorators": true, | ||
| // "emitDecoratorMetadata": true, | ||
|
|
||
| /* Advanced Options */ | ||
| "noErrorTruncation": true, | ||
| "declarationDir": "lib", | ||
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already incremental included in this list why is there another entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess that was automerged and I missed it - pushed a fix for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please existing entry instead? Is there reason this needs to move ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better now?