Fix type reference to merged prototype property assignment #34764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor function code path in the return type checking of signatures needs to pass the *merged* symbol of the declaration to getDeclaredTypeOfClassOrInterface. Other callers of getDeclaredTypeOfClassOrInterface do this, or used an already-merged symbol. Fixes #33993
andrewbranch
approved these changes
Oct 28, 2019
sandersn
deleted the
fix-type-reference-to-merged-prototype-property-assignment
branch
|
@typescript-bot cherry-pick this to release-3.7 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 28, 2019
Component commits: ab9bc3a Fix type reference to merged prototype property assignment The constructor function code path in the return type checking of signatures needs to pass the *merged* symbol of the declaration to getDeclaredTypeOfClassOrInterface. Other callers of getDeclaredTypeOfClassOrInterface do this, or used an already-merged symbol. Fixes microsoft#33993
sandersn
pushed a commit
that referenced
this pull request
Oct 28, 2019
Component commits: ab9bc3a Fix type reference to merged prototype property assignment The constructor function code path in the return type checking of signatures needs to pass the *merged* symbol of the declaration to getDeclaredTypeOfClassOrInterface. Other callers of getDeclaredTypeOfClassOrInterface do this, or used an already-merged symbol. Fixes #33993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor function code path in the return type checking of signatures needs to pass the merged symbol of the declaration to getDeclaredTypeOfClassOrInterface. Other callers of getDeclaredTypeOfClassOrInterface do this, or used an already-merged symbol.
Fixes #33993
For background, this call is new in the code path -- before 3.7, constructor functions were not classes and fell through to
getReturnTypeOfSignature, where they would retrieve the type put there earlier by ad-hoc code.getDeclaredTypeOfClassOrInterfaceinvokes the full class creation machinery but asserts that the symbol is correctly marked with the Class flag. If it's not, fails in a number of places. (The assertion postdates the filing of the bug.)