Fix: convertFunctionToEs6Class cannot recognize x.prototype = {} pattern

[Jack-Works]

Currently, TypeScript's fixer cannot recognize this pattern:

function X() {}
X.prototype = {
    method(): {}
}

This PR add the ability to recognize this pattern.

Before

After

[andrewbranch]

Thanks for adding this! I think it looks good, but I don’t think we can merge it without some accompanying tests. (If we make changes here in the future, we need to know what this does and whether our new changes are breaking it. Uncovered code tends to get broken or deleted eventually.)

[andrewbranch]

Also, I just noticed how old this PR is, and I’m sorry for the delay—I know it’s not super cool to leave this sitting for 5 months and then request changes. We’re finally making a real effort to get our PR backlog organized, so hopefully we’ll be faster to respond in the future. Thanks for understanding ❤️

[Jack-Works]

cool, I'll add some test later

[ExE-Boss]

What about:

function Bar(...args) {
	// code
}

Bar.prototype = {
	// Should be ignored, as classes already include this:
	constructor: Bar,

	// Should result in `someField` being added to the class as a field.
	someField: 123,
};

[Jack-Works]

What about:

function Bar(...args) {
	// code
}

Bar.prototype = {
	// Should be ignored, as classes already include this:
	constructor: Bar,

	// Should result in `someField` being added to the class as a field.
	someField: 123,
};

The removal of constructor is done. But the class field is not implemented yet. (And I'm doubting the runtime behavior of prototype and class field are different.)

[Jack-Works]

@andrewbranch hi I need help. the tests passed on my machine but not on CI

[andrewbranch]

@Jack-Works unrelated to the failures, but can you move your test files out from the server subdirectory of fourslash? (That folder runs with additional mocking infrastructure that shouldn’t be relevant to your tests.) Secondly, it looks like the failures are due to a newline character mismatch in your expected output. Maybe git rewrote line endings in your commit. Try to normalize all the line endings in your test files, and ensure whatever you pick doesn’t get overridden by git or your editor on save. My guess is that some process tried to normalize line endings for you, but refused to change the contents of a template string. So, the actual content (the part with the four slashes) changed, but the expected content in the template string did not.

[andrewbranch]

Awesome, thanks for iterating on the original code; this is much easier to read now 🌟

[Jack-Works]

hi @andrewbranch when to merge?

[andrewbranch]

Thanks for the reminder, we were waiting until master reflected 4.0.